netdev - Re: [PATCH RESEND net] net/mlx4_en: Limit the RFS filter IDs to be < RPS_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120725.152337.155627167530086828.davem@davemloft.net>
Date:	Wed, 25 Jul 2012 15:23:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org,
	oren@...lanox.com, amirv@...lanox.com
Subject: Re: [PATCH RESEND net] net/mlx4_en: Limit the RFS filter IDs to be
 < RPS_NO_FILTER

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Wed, 25 Jul 2012 18:04:35 +0300

> On 25/07/2012 17:57, Ben Hutchings wrote:
>>> @@ -77,12 +77,8 @@ int mlx4_en_activate_cq(struct mlx4_en_priv *priv,
>>> struct mlx4_en_cq *cq,
>>>   	struct mlx4_en_dev *mdev = priv->mdev;
>>>   	int err = 0;
>>>   	char name[25];
>>> -	struct cpu_rmap *rmap =
>>> -#ifdef CONFIG_RFS_ACCEL
>>> -		priv->dev->rx_cpu_rmap;
>>> -#else
>>> -		NULL;
>>> -#endif
>>> +	struct cpu_rmap *rmap = IS_ENABLED(CONFIG_RFS_ACCEL) ?
>>> +		priv->dev->rx_cpu_rmap : NULL;
>>
>> This is a separate change.
> 
> OK, will send two patches

This change breaks the build.

You can't do this check at run-time, because the reason you need to
check CONFIG_RFS_ACCEL is because if that's disabled then the netdev
structure doesn't even have the ->rx_cpu_rmap member.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html