netdev - Re: [RFC NET-NEXT PATCH 5/6] e1000e: implement MDI/MDI-X control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1343256239.5132.150.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 25 Jul 2012 23:43:59 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jesse Brandeburg <jesse.brandeburg@...el.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: [RFC NET-NEXT PATCH 5/6] e1000e: implement MDI/MDI-X control

On Wed, 2012-07-25 at 11:00 -0700, Jesse Brandeburg wrote:
> some users report issues with link failing when connected to certain
> switches.  This gives the user the ability to control the MDI state
> from the driver, allowing users to work around some improperly
> behaving switches.
> 
> forcing in this driver is for now only allowed when auto-neg is
> enabled.
[...]
> --- a/drivers/net/ethernet/intel/e1000e/ethtool.c
> +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c
[...] 
> @@ -241,6 +246,10 @@ static int e1000_set_spd_dplx(struct e1000_adapter *adapter, u32 spd, u8 dplx)
>  	default:
>  		goto err_inval;
>  	}
> +
> +	/* clear MDI, MDI(-X) override is only allowed when autoneg enabled */
> +	adapter->hw.phy.mdix = AUTO_ALL_MODES;
> +
[...]

I have the same question about this assignment as in e1000.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html