netdev - Re: [PATCH] bcma: fix regression in pmu workaround reg masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120726.030659.2063192496743861099.davem@davemloft.net>
Date:	Thu, 26 Jul 2012 03:06:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hauke@...ke-m.de
Cc:	torvalds@...ux-foundation.org, linville@...driver.com,
	brcm80211-dev-list@...adcom.com, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	seth.forshee@...onical.com, pieterpg@...adcom.com,
	brudley@...adcom.com, arend@...adcom.com, zajec5@...il.com
Subject: Re: [PATCH] bcma: fix regression in pmu workaround reg masks

From: Hauke Mehrtens <hauke@...ke-m.de>
Date: Thu, 26 Jul 2012 11:15:51 +0200

> This fixes a regression introduced in:
> commit b9562545ef0b13c0440ccd8d6dd4111fb77cb17a
> Author: Hauke Mehrtens <hauke@...ke-m.de>
> Date:   Sat Jun 30 01:44:41 2012 +0200
> 
>     bcma: complete workaround for BCMA43224 and BCM4313
> 
> The regression broke reading of the sprom from the chip and seamed to
> cause a change of the pci id on a BCMA43224 device so that it is
> rejected by brcmsmac. If this problem occurred, after applying this
> patch, a cold boot is needed to make the device work again.
> 
> In the original patch the workaround set the intended bits in the chip
> common core chip control registers, but the patch also unset all the
> other bits in that register, because of a wrong mask. The original
> patch was based on code from brcmsmac and there was an additional
> inversing of the mask in the code setting these regs which was missing
> here. Now the regs are set like brcmsmac did it before.
> 
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> Reported-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Tested-by: Seth Forshee <seth.forshee@...onical.com>

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html