netdev - Re: open sockets preventing unregister_netdevice from completing in linux-next (next-20120724)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1343322928.2626.11764.camel@edumazet-glaptop>
Date:	Thu, 26 Jul 2012 19:15:28 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	bjorn@...k.no, netdev@...r.kernel.org
Subject: Re: open sockets preventing unregister_netdevice from completing
 in linux-next (next-20120724)

On Wed, 2012-07-25 at 15:17 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Wed, 25 Jul 2012 16:38:48 +0200
> 
> > Yes, we miss what was done with rt_cache_flush() : find all cached
> > routes and release all dev references...
> 
> We can fix this with a two-pronged approach:
> 
> 1) Walk the FIB info nexthops and invalidate.
> 
> 2) Entries not cached in the FIB info nexthops go into a
>    per-netns list which is scanned as well.
> 
> I'll try to work on this if nobody beats me to it.

With your latest patch, I can "rmmod tg3" while sockets are active.

Not sure we need all this now ?

(the trick is probably in fib_semantics.c, when you changed
dst_release() to dst_free())



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html