lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120727085021.1d4ef810@nehalam.linuxnetplumber.net> Date: Fri, 27 Jul 2012 08:50:21 -0700 From: Stephen Hemminger <shemminger@...tta.com> To: Cong Wang <amwang@...hat.com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/7] bridge: call NETDEV_RELEASE notifier in br_del_if() On Fri, 27 Jul 2012 23:38:01 +0800 Cong Wang <amwang@...hat.com> wrote: > When a bridge interface deletes its underlying ports, it should > notify netconsole too, like what bonding interface does. > > Cc: "David S. Miller" <davem@...emloft.net> > Signed-off-by: Cong Wang <amwang@...hat.com> > --- > net/bridge/br_if.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c > index e1144e1..d243914 100644 > --- a/net/bridge/br_if.c > +++ b/net/bridge/br_if.c > @@ -427,6 +427,7 @@ int br_del_if(struct net_bridge *br, struct net_device *dev) > if (!p || p->br != br) > return -EINVAL; > > + call_netdevice_notifiers(NETDEV_RELEASE, br->dev); > del_nbp(p); > > spin_lock_bh(&br->lock); Since you can have multiple ports attached to the bridge, this doesn't seem correct. Don't you want the netconsole to keep going on the other ports of the bridge? What exactly is the problem with having netconsole persist? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists