netdev - Re: [PATCH] net: fix rtnetlink IFF_PROMISC and IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120727.134650.366843201370833087.davem@davemloft.net>
Date:	Fri, 27 Jul 2012 13:46:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, makc@...hat.com
Subject: Re: [PATCH] net: fix rtnetlink IFF_PROMISC and IFF_ALLMULTI
 handling

From: Jiri Benc <jbenc@...hat.com>
Date: Fri, 27 Jul 2012 14:58:22 +0200

> When device flags are set using rtnetlink, IFF_PROMISC and IFF_ALLMULTI
> flags are handled specially. Function dev_change_flags sets IFF_PROMISC and
> IFF_ALLMULTI bits in dev->gflags according to the passed value but
> do_setlink passes a result of rtnl_dev_combine_flags which takes those bits
> from dev->flags.
> 
> This can be easily trigerred by doing:
> 
> tcpdump -i eth0 &
> ip l s up eth0
> 
> ip sets IFF_UP flag in ifi_flags and ifi_change, which is combined with
> IFF_PROMISC by rtnl_dev_combine_flags, causing __dev_change_flags to set
> IFF_PROMISC in gflags.
> 
> Reported-by: Max Matveev <makc@...hat.com>
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html