netdev - Re: [PATCH] net:appletalk:ddp:fixed some codystyle issues in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1343485593.2009.8.camel@joe2Laptop>
Date:	Sat, 28 Jul 2012 07:26:33 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
Cc:	acme@...stprotocols.net, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net:appletalk:ddp:fixed some codystyle issues in

On Sat, 2012-07-28 at 16:15 +0530, Jeffrin Jose wrote:
> Fixed coding style issues relating to indentation found in
> net/appletalkddp.c."git diff -w" is empty and the compiled objects
> are the same too.

Hello Jeffrin.

Your commit message is OK but your patch not.

The switch/case that could use modification is at
line 1790, not at line 685.

> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
[]
> @@ -337,7 +337,7 @@ static int atif_proxy_probe_device(struct atalk_iface *atif,
>  
>  	return -EADDRINUSE;	/* Network is full... */
>  }
> -
> +   

Adding whitespace
 
>  struct atalk_addr *atalk_find_dev_addr(struct net_device *dev)
>  {
> @@ -685,26 +685,26 @@ static int atif_ioctl(int cmd, void __user *arg)
>  
>  	switch (cmd) {
>  	case SIOCSIFADDR:
> -		if (!capable(CAP_NET_ADMIN))
> +			if (!capable(CAP_NET_ADMIN))

There's nothing wrong here to fix and you are
adding incorrect indentation.

Please try again and make sure you verify your
proposed patches by using scripts/checkpatch.pl
before submitting them.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html