netdev - Re]: [PATCH net-next v2] GRE over IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 29 Jul 2012 11:44:43 +0400
From:	Dmitry Kozlov <xeb@...l.ru>
To:	Eric W. Biederman <ebiederm@...ssion.com>
Cc:	netdev@...r.kernel.org
Subject: Re]: [PATCH net-next v2] GRE over IPv6

Eric W. Biederman <ebiederm@...ssion.com> wrote:
> >
> >> Why are you implementing an ioctl based instead of using netlink?
> >> Last I looked using netlink to create and delete tunnels was more
> >> flexible and the preferred method and the existing ioctl based methods
> >> were simply being maintained for backwards compatibility.
> > I have implemented both ioctl and netlink based.
> > So if ioctl based is unnecessary it is not difficult to remove this
> > part.
> >
> >> Also it appears that you have failed to include the all important
> >> ip6_gre.c
> > What do you mean ?
> 
> I mean quit simply your patch adds to the Makefile the line:
> obj-$(CONFIG_IPV6_GRE) += ip6_gre.o
> 
> But that your patch does not include a file named ip6_gre.c
> Also your patch description talks about ip6gre_tnl_link_config and
> ip6gre_newlink but those functions do not exist in your patch.  I
> presume those functions are implemented in the missing ip6_gre.c
> 
> So please read the patch you sent to the mailing list and figure
> out which file or files are missing.
Thank you for your suggestion, I will resend patch...