netdev - Re: [PATCH v2 3/6] mv643xx.c: Add basic device tree support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201207312018.33432.arnd@arndb.de>
Date:	Tue, 31 Jul 2012 20:18:32 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Ian Molton <ian.molton@...ethink.co.uk>,
	linux-arm-kernel@...ts.infradead.org,
	thomas.petazzoni@...e-electrons.com, ben.dooks@...ethink.co.uk,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 3/6] mv643xx.c: Add basic device tree support.

On Tuesday 31 July 2012, Andrew Lunn wrote:
> This pattern is used in other places, e.g. when creating the
> clocks. The macro MV643XX_ETH_NAME is also used when creating the
> platform data, and in the driver itself. 
> 
> Are you suggested we replace this with "mv643xx_eth.0"? Or is adding
> the macro
> 
> #define MV643XX_ETH_NAME0 "mv643xx_eth.0" 
> 
> in include/linux/mv643xx_eth.h O.K, since grep will find it, and
> induce the grep'er to perform a second grep on the macro?

I meant the former. Just remove the macro entirely, or at least
don't add new users.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html