netdev - Re: [PATCH 1/2] net: davinci_mdio: enable and disable clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <501AE074.8090906@gmail.com>
Date:	Thu, 02 Aug 2012 22:17:56 +0200
From:	Daniel Mack <zonque@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	netdev@...r.kernel.org, mugunthanvnm@...com, paul@...an.com,
	devicetree-discuss@...ts.ozlabs.org, koen@...inion.thruhere.net,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] net: davinci_mdio: enable and disable clock

On 02.08.2012 21:53, Russell King - ARM Linux wrote:
> On Thu, Aug 02, 2012 at 09:43:35PM +0200, Daniel Mack wrote:
>> Make the driver control the device clocks. Appearantly, the Davinci
>> platform probes this driver with the clock all powered up, but on OMAP,
>> this isn't the case.
> 
> Hmm, this looks like it could do with improvement, especially as we're
> moving everything over to a common clk API.
> 
> 1. This driver could do with clk_prepare()/clk_unprepare() calls.

Ok, done.

> 2. This driver should not be making the assumption that NULL means
>    it can avoid clk_* calls.  It should instead be using
> 	if (!IS_ERR(clk))

Well spotted. Amended patch below.


Thanks,
Daniel




View attachment "0001-net-davinci_mdio-prepare-and-unprepare-clocks.patch" of type "text/x-patch" (2046 bytes)