lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 03 Aug 2012 01:52:43 -0700 (PDT) From: David Miller <davem@...emloft.net> To: sakiwit@...il.com Cc: netdev@...r.kernel.org Subject: Re: [PATCH] ipv4: remove parentheses in return statement From: Jean Sacren <sakiwit@...il.com> Date: Fri, 3 Aug 2012 01:43:10 -0600 > It is always wrong to write 'return (...)'. In your imagination. > After removal, realign the code where necessary. > > Signed-off-by: Jean Sacren <sakiwit@...il.com> > - return ((val ^ (val >> 8) ^ (val >> 16) ^ (val >> 24)) & > - (IN4_ADDR_HSIZE - 1)); > + return (val ^ (val >> 8) ^ (val >> 16) ^ (val >> 24)) & > + (IN4_ADDR_HSIZE - 1); Those parenthesis are there to make the evaluation order and grouping explicit. The other ones you changed are wrong for similar reasons. I absolutely am not applying patches like this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists