netdev - Re: [PATCH V1 2/3] net/mlx4_en: Fixing TX queue stop/wake flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120803.164959.1852290857085579847.davem@davemloft.net>
Date:	Fri, 03 Aug 2012 16:49:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yevgenyp@...lanox.co.il
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH V1 2/3] net/mlx4_en: Fixing TX queue stop/wake flow

From: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Date: Fri,  3 Aug 2012 13:38:37 +0300

> Removing the ring->blocked flag, it is redundant and leads to a race:
> 
> We close the TX queue and then set the "blocked" flag.
> Between those 2 operations the completion function can check the "blocked"
> flag, sees that it is 0, and wouldn't open the TX queue.
> 
> Using netif_tx_queue_stopped to check the state of the queue to avoid this race.
> 
> Signed-off-by: Yevgeny Petrilin <yevgenyp@...lanox.co.il>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html