netdev - Re: [PATCH v2] ppp: add 64 bit stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120803.204141.445487530122768077.davem@davemloft.net>
Date:	Fri, 03 Aug 2012 20:41:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	kgroeneveld@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] ppp: add 64 bit stats

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 28 Jul 2012 09:39:01 +0200

> On Fri, 2012-07-27 at 23:38 -0400, Kevin Groeneveld wrote:
>> Add 64 bit stats to ppp driver.  The 64 bit stats include tx_bytes,
>> rx_bytes, tx_packets and rx_packets.  Other stats are still 32 bit.
>> The 64 bit stats can be retrieved via the ndo_get_stats operation.  The
>> SIOCGPPPSTATS ioctl is still 32 bit stats only.
>> 
>> Signed-off-by: Kevin Groeneveld <kgroeneveld@...il.com>
>> ---
>> v2: - do not use percpu variables for stats
>>     - use ppp_recv_lock/ppp_xmit_lock when reading 64 bit stats
>> 
> 
> Seems fine to me this time ;)
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html