netdev - Re: skb_warn_bad_offload with kernel 3.5 (maybe gso/bridge related ?)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120806091846.GA18581@gondor.apana.org.au>
Date:	Mon, 6 Aug 2012 17:18:46 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Yann Dupont <Yann.Dupont@...v-nantes.fr>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: skb_warn_bad_offload with kernel 3.5 (maybe gso/bridge related
 ?)

On Fri, Aug 03, 2012 at 04:40:08PM +0100, Ben Hutchings wrote:
>
> I think GRO is doing the right thing, and I can't think why we should
> see ip_summed = CHECKSUM_PARTIAL if the skb is forwarded by a bridge.  I

If it is was created by GRO then it should always be CHECKSUM_PARTIAL,
even if it came through a bridge.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html