netdev - Re: [PATCH 1/5] net: Don't use ifindices in hash fns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <501FA3FA.9010107@parallels.com>
Date:	Mon, 06 Aug 2012 15:01:14 +0400
From:	Pavel Emelyanov <xemul@...allels.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	David Miller <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/5] net: Don't use ifindices in hash fns

On 08/06/2012 02:43 PM, Eric Dumazet wrote:
> On Mon, 2012-08-06 at 14:30 +0400, Pavel Emelyanov wrote:
>> Eric noticed, that when there will be devices with equal indices, some
>> hash functions that use them will become less effective as they could.
>>
>> Fix this in advance by taking the net_device address into calculations
>> instead of the device index. Since the net_device is always aligned in
>> memory, shift the pointer to eliminate always zero bits (like we do it
>> in net_hash_mix).
>>
>> This is true for arp and ndisc hash fns. The netlabel, can and llc ones
>> are also ifindex-based, but that three are init_net-only, thus will not
>> be affected.
>>
>> Signed-off-by: Pavel Emelyanov <xemul@...allels.com>
>>
>> ---
>>  include/linux/netdevice.h |    6 ++++++
>>  include/net/arp.h         |    2 +-
>>  include/net/ndisc.h       |    2 +-
>>  3 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index a9db4f3..6010b37 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -1330,6 +1330,12 @@ struct net_device {
>>  
>>  #define	NETDEV_ALIGN		32
>>  
>> +static inline unsigned int netdev_hash_mix(const struct net_device *dev)
>> +{
>> +	return (unsigned int)(((unsigned long)dev) >>
>> +			max(L1_CACHE_BYTES, NETDEV_ALIGN));
>> +}
>> +
> 
> I guess you didnt test this patch very well ...

Damn :( You're right.

> This returns 0 as is

Well, on 64-bit no, but what it does is also not what it was supposed to.

> I would define a generic pointer hash mix instead of a 'net_device
> thing'
> 
> static inline u32 ptr_hash_mix(void *ptr)
> {
> #if BITS_PER_LONG==32
> 	return (u32)(unsigned long)ptr;
> #else
> 	return (u32)((unsigned long)ptr >> L1_CACHE_SHIFT);
> #endif
> }

OK. It will also obsolete the net_hash_mix then. Any suggestions where to put
the new one?

Thanks,
Pavel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html