netdev - Re: [PATCH RFC] net: tcp: GRO should be ECN friendly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120806090150.GB18425@gondor.apana.org.au>
Date:	Mon, 6 Aug 2012 17:01:50 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH RFC] net: tcp: GRO should be ECN friendly

On Mon, Aug 06, 2012 at 10:34:50AM +0200, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> While doing TCP ECN tests, I discovered GRO was reordering packets if it
> receives one packet with CE set, while previous packets in same NAPI run
> have ECT(0) for the same flow :
> 
> 09:25:25.857620 IP (tos 0x2,ECT(0), ttl 64, id 27893, offset 0, flags
> [DF], proto TCP (6), length 4396)
>     172.30.42.19.54550 > 172.30.42.13.44139: Flags [.], seq
> 233801:238145, ack 1, win 115, options [nop,nop,TS val 3397779 ecr
> 1990627], length 4344
> 
> 09:25:25.857626 IP (tos 0x3,CE, ttl 64, id 27892, offset 0, flags [DF],
> proto TCP (6), length 1500)
>     172.30.42.19.54550 > 172.30.42.13.44139: Flags [.], seq
> 232353:233801, ack 1, win 115, options [nop,nop,TS val 3397779 ecr
> 1990627], length 1448
> 
> 09:25:25.857638 IP (tos 0x0, ttl 64, id 34581, offset 0, flags [DF],
> proto TCP (6), length 64)
>     172.30.42.13.44139 > 172.30.42.19.54550: Flags [.], cksum 0xac8f
> (incorrect -> 0xca69), ack 232353, win 1271, options [nop,nop,TS val
> 1990627 ecr 3397779,nop,nop,sack 1 {233801:238145}], length 0
> 
> We have two problems here :
> 
> 1) GRO reorders packets
> 
>   If NIC gave packet1, then packet2, which happen to be from "different
> flows"  GRO feeds stack with packet2, then packet1. I have yet to
> understand how to solve this problem.
> 
> 2) GRO is not ECN friendly
> 
> Delivering packets out of order makes TCP stack not as fast as it could
> be.
> 
> In this patch I suggest we make the tos test not part of the 'same_flow'
> determination, but part of the 'should flush' logic
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Good catch, thanks Eric!
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html