netdev - Re: [PATCH] configure: Add search path for 64bit library.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1344363358.2688.8.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Tue, 7 Aug 2012 19:15:58 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Li Wei <lw@...fujitsu.com>
CC:	<shemminger@...tta.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] configure: Add search path for 64bit library.

The subject line doesn't say what this is for, but it looks like
iproute2...

On Tue, 2012-08-07 at 12:22 +0800, Li Wei wrote:
> Signed-off-by: Li Wei <lw@...fujitsu.com>
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 0f4444f..997759c 100755
> --- a/configure
> +++ b/configure
> @@ -149,7 +149,7 @@ check_ipt()
>  check_ipt_lib_dir()
>  {
>  	IPT_LIB_DIR=""
> -	for dir in /lib /usr/lib /usr/local/lib
> +	for dir in /lib /usr/lib /usr/local/lib /lib64 /usr/lib64 /usr/local/lib64
>  	do
>  		for file in $dir/{xtables,iptables}/lib*t_*so ; do
>  			if [ -f $file ]; then

On a bi-arch system, surely the lib64 directories should be preferred to
the lib directories?  And this still leaves multi-arch to be handled.

I think this should be done with pkg-config:

    pkg-config --variable=xtlibdir xtables

possibly with that directory list as a fallback if it's useful to
support iptables library versions that didn't include xtables.pc.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html