netdev - Re: [PATCH 1/6] hash: Introduce ptr_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120807.143933.556038665324374825.davem@davemloft.net>
Date:	Tue, 07 Aug 2012 14:39:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xemul@...allels.com
Cc:	eric.dumazet@...il.com, ebiederm@...ssion.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/6] hash: Introduce ptr_hash_mix routine

From: Pavel Emelyanov <xemul@...allels.com>
Date: Tue, 07 Aug 2012 13:11:41 +0400

> Maybe it would be better to change the way neigh_table->hash work more
> significantly then? Currently it is used like
> 
> 	hash = tbl->hash(key, dev, tbl->rnd);
> 	hash >>= (32 - tbl->hash_shift);
> 
> i.e. the caller asks for u32 hash value and then trims some lower bits.

We do this because the hash function we use in the neigh
implementations causes the top bits to have the most entropy.

Please look at the commits that made the code this way, it's
very much intentional.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html