netdev - Re: [PATCH v3 0/14] some netpoll and netconsole fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120809.163616.132379032405824162.davem@davemloft.net>
Date:	Thu, 09 Aug 2012 16:36:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3 0/14] some netpoll and netconsole fixes

From: David Miller <davem@...emloft.net>
Date: Thu, 09 Aug 2012 16:30:46 -0700 (PDT)

> From: Cong Wang <amwang@...hat.com>
> Date: Thu,  9 Aug 2012 23:00:12 +0800
> 
>> V3:
>> * add more patches
>> * update patch 7 as David suggested
>> 
>> V2:
>> * update patch 1/8 as Eric suggested
>> * drop the bridge patch, add comments instead
>> * add patch 8/8
>> 
>> This patchset fixes serval problems in netconsole and netpoll.
>> 
>> I ran this patch in my KVM guest with some netpoll test cases,
>> even covered with some corner cases, everything worked as expected.
> 
> All applied to 'net', thanks for fixing all of this stuff.

Actually, you didn't test the build very well, I'm reverting:

In file included from drivers/net/team/team_mode_broadcast.c:17:0:
include/linux/if_team.h: In function ‘team_dev_queue_xmit’:
include/linux/if_team.h:107:6: error: dereferencing pointer to incomplete type
make[3]: *** [drivers/net/team/team_mode_broadcast.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from drivers/net/team/team.c:31:0:
include/linux/if_team.h: In function ‘team_dev_queue_xmit’:
include/linux/if_team.h:107:6: error: dereferencing pointer to incomplete type
make[3]: *** [drivers/net/team/team.o] Error 1
make[2]: *** [drivers/net/team] Error 2
make[2]: *** Waiting for unfinished jobs....