netdev - Re: [PATCH] net: add new QCA alx ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1344538611.2593.4.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Thu, 9 Aug 2012 19:56:51 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Joe Perches <joe@...ches.com>,
	"Ren, Cloud" <cjren@....qualcomm.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	qca-linux-team <qca-linux-team@...lcomm.com>,
	nic-devel <nic-devel@...lcomm.com>,
	"Huang, Xiong" <xiong@....qualcomm.com>,
	"hao-ran.liu@...onical.com" <hao-ran.liu@...onical.com>,
	"Rodriguez, Luis" <rodrigue@....qualcomm.com>
Subject: Re: [PATCH] net: add new QCA alx ethernet driver

On Thu, 2012-08-09 at 11:28 -0400, Steven Rostedt wrote:
> On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote:
> 
> > Yes, I sent signed-off patches to their original RFC submission
> > (back last year?).  To me, this single large patch is like a
> > snapshot of a git tree and not all contributors to that git
> > tree should be noted as signers of the entire thing.
> 
> Ouch, that looks like we are losing all history.
> 
> One large patch should not be submitted. If it was developed in steps,
> then it is best to show those steps when they are incorporated into the
> Linux repository.
> 
> Sure, the patches may be reworked and folded together where appropriate,
> but when I read "this single large patch is like a snapshot of a git
> tree", that right there is a red flag.

I don't think this has ever been a requirement for new drivers.

The alterations to the description of atl1c ought to be broken out as a
separate patch, though.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html