netdev - Re: [net-next] bonding: don't allow the master to become its slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5023DB0B02000086000C9D31@novprvoes0310.provo.novell.com>
Date:	Thu, 09 Aug 2012 12:45:15 -0600
From:	"Leonardo Chiquitto" <lchiquitto@...e.com>
To:	"Flavio Leitner" <fbl@...hat.com>,
	"netdev" <netdev@...r.kernel.org>
Cc:	"Andy Gospodarek" <andy@...yhouse.net>,
	"Jay Vosburgh" <fubar@...ibm.com>
Subject: Re: [net-next] bonding: don't allow the master to become its
 slave

>>> On 8/9/2012 at 03:30 PM, Flavio Leitner <fbl@...hat.com> wrote: 
> It doesn't make any sense to allow the master to become
> its slave. That creates a loop of events causing a crash.
> 
> Reported-by: Leonardo Chiquitto <lchiquitto@...e.com>
> Signed-off-by: Flavio Leitner <fbl@...hat.com>
> ---
>  drivers/net/bonding/bond_main.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 6fae5f3..5407b44 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1505,6 +1505,11 @@ int bond_enslave(struct net_device *bond_dev, struct 
> net_device *slave_dev)
>  	int link_reporting;
>  	int res = 0;
>  
> +	if (bond_dev == slave_dev) {
> +		pr_err("%s: Error: cannot enslave itself.\n", bond_dev->name);
> +		return -EINVAL;
> +	}
> +
>  	if (!bond->params.use_carrier && slave_dev->ethtool_ops == NULL &&
>  		slave_ops->ndo_do_ioctl == NULL) {
>  		pr_warning("%s: Warning: no link monitoring support for %s\n",

I've tested it here and confirm it prevents the crash.

Tested-by: Leonardo Chiquitto <lchiquitto@...e.com>

Thanks,
Leonardo

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html