netdev - Re: [PATCH] XFRM: remove redundant parameter "int dir" in struct xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120813070841.GP1869@secunet.com>
Date:	Mon, 13 Aug 2012 09:08:41 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Fan Du <fan.du@...driver.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] XFRM: remove redundant parameter "int dir" in struct
 xfrm_mgr.acquire

On Mon, Aug 13, 2012 at 02:25:57PM +0800, Fan Du wrote:
>  
>  static int xfrm_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *xt,
> -			     struct xfrm_policy *xp, int dir)
> +			     struct xfrm_policy *xp)
>  {
>  	struct net *net = xs_net(x);
>  	struct sk_buff *skb;
> @@ -2614,7 +2614,7 @@ static int xfrm_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *xt,
>  	if (skb == NULL)
>  		return -ENOMEM;
>  
> -	if (build_acquire(skb, x, xt, xp, dir) < 0)
> +	if (build_acquire(skb, x, xt, xp, XFRM_POLICY_OUT) < 0)
>  		BUG();

xfrm_send_acquire() is the only caller of build_acquire().
So if you remove the dir parameter from xfrm_send_acquire(),
you can remove it from build_acquire() too. 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html