lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1344848911.5849.10.camel@joe2Laptop> Date: Mon, 13 Aug 2012 02:08:31 -0700 From: Joe Perches <joe@...ches.com> To: John Fastabend <john.r.fastabend@...el.com> Cc: Al Viro <viro@...IV.linux.org.uk>, netdev@...r.kernel.org, David Miller <davem@...emloft.net>, Neil Horman <nhorman@...driver.com>, linux-kernel@...r.kernel.org Subject: Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic On Sun, 2012-08-12 at 22:55 -0700, John Fastabend wrote: > On 8/12/2012 6:53 PM, Al Viro wrote: > > Ladies and gentlemen, who the devil had reviewed that little gem? > > > > commit 406a3c638ce8b17d9704052c07955490f732c2b8 > > Author: John Fastabend <john.r.fastabend@...el.com> > > Date: Fri Jul 20 10:39:25 2012 +0000 [] > OK clearly I screwed it up thanks for reviewing Al. How about this. > > fdt = files_fdtable(files); > for (fd = 0; fd < fdt->max_fds; fd++) { > struct socket *sock; > int err = 0; Don't need to initialize err if you're not using it. > sock = sockfd_lookup(fd, &err); > if (!sock) { Of course you mean if (sock) > lock_sock(sock->sk); > sock_update_netprioidx(sock->sk, p); > release_sock(sock->sk); > sockfd_put(sock); > } > } -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists