netdev - Re: [PATCH] net: remove wrong initialization for snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120815.152334.334391000010431604.davem@davemloft.net>
Date:	Wed, 15 Aug 2012 15:23:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rghitulete@...acom.com
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, netdev@...r.kernel.org, dbaluta@...acom.com
Subject: Re: [PATCH] net: remove wrong initialization for snd_wl1

From: Razvan Ghitulete <rghitulete@...acom.com>
Date: Tue, 14 Aug 2012 16:30:20 +0300

> The field tp->snd_wl1 is twice initialized, the second time
> seems to be wrong as it may overwrite any update in tcp_ack.
> 
> Signed-off-by: Razvan Ghitulete <rghitulete@...acom.com>

I'll apply this, but it is mere redundancy.

The only thing tcp_ack() can set tp->snd_wl1 to is TCP_SKB_CB(skb)->seq
which is exactly what it is being set to here as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html