netdev - Re: [PATCH net] ipv6: addrconf: Avoid calling netdevice notifiers with RCU read-side lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120814.170257.442769610103100016.davem@davemloft.net>
Date:	Tue, 14 Aug 2012 17:02:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, john.r.fastabend@...el.com,
	gregory.v.rose@...el.com, tgraf@...g.ch, edumazet@...gle.com,
	amwang@...hat.com
Subject: Re: [PATCH net] ipv6: addrconf: Avoid calling netdevice notifiers
 with RCU read-side lock

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Tue, 14 Aug 2012 19:54:51 +0100

> Cong Wang reports that lockdep detected suspicious RCU usage while
> enabling IPV6 forwarding:
 ...
> addrconf_forward_change() uses RCU iteration over the netdev list,
> which is unnecessary since it already holds the RTNL lock.  We also
> cannot reasonably require netdevice notifier functions not to sleep.
> 
> Reported-by: Cong Wang <amwang@...hat.com>
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Applied and queued up for -stable, thanks Ben.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html