netdev - Re: [Patch net-next] sctp: fix a compile error in sctp.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120815.034501.1424538455974526416.davem@davemloft.net>
Date:	Wed, 15 Aug 2012 03:45:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, ebiederm@...ssion.com
Subject: Re: [Patch net-next] sctp: fix a compile error in sctp.h

From: Cong Wang <amwang@...hat.com>
Date: Wed, 15 Aug 2012 18:18:11 +0800

> I got the following compile error:
> 
> In file included from include/net/sctp/checksum.h:46:0,
>                  from net/ipv4/netfilter/nf_nat_proto_sctp.c:14:
> include/net/sctp/sctp.h: In function ‘sctp_dbg_objcnt_init’:
> include/net/sctp/sctp.h:370:88: error: parameter name omitted
> include/net/sctp/sctp.h: In function ‘sctp_dbg_objcnt_exit’:
> include/net/sctp/sctp.h:371:88: error: parameter name omitted
> 
> which is caused by
> 
> 	commit 13d782f6b4fbbaf9d0380a9947deb45a9de46ae7
> 	Author: Eric W. Biederman <ebiederm@...ssion.com>
> 	Date:   Mon Aug 6 08:45:15 2012 +0000
> 
> 	    sctp: Make the proc files per network namespace.
> 
> This patch could fix it.
> 
> Cc: David S. Miller <davem@...emloft.net>
> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
> Signed-off-by: Cong Wang <amwang@...hat.com>

Applied thanks.

I appended the SCTP debug objcnt procfs netns conversions by hand
since Eric didn't handle it in his commit.

Eric, please turn all relevant options both on and off when testing
the build of your patches.  Thanks.