netdev - Re: [PATCH] net: add new QCA alx ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120815080226.388ea856@nehalam.linuxnetplumber.net>
Date:	Wed, 15 Aug 2012 08:02:26 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	"Ren, Cloud" <cjren@....qualcomm.com>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	qca-linux-team <qca-linux-team@...lcomm.com>,
	nic-devel <nic-devel@...lcomm.com>,
	"Huang, Xiong" <xiong@....qualcomm.com>,
	"hao-ran.liu@...onical.com" <hao-ran.liu@...onical.com>,
	"joe@...ches.com" <joe@...ches.com>,
	"Rodriguez, Luis" <rodrigue@....qualcomm.com>
Subject: Re: [PATCH] net: add new QCA alx ethernet driver

On Wed, 15 Aug 2012 05:39:11 +0000
"Ren, Cloud" <cjren@....qualcomm.com> wrote:

> From: David Miller [mailto:davem@...emloft.net]
> Sent: Wednesday, August 15, 2012 1:33 PM
> 
> >From: "Ren, Cloud" <cjren@....qualcomm.com>
> >Date: Wed, 15 Aug 2012 03:29:26 +0000
> >
> >>>> +	strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1);
> >>>> ...
> >>>> +	strcpy(netdev->name, "eth%d");
> >>>> +	retval = register_netdev(netdev);
> >>>
> >>>The strcpy is unnecessary, alloc_etherdev already sets that.
> >>
> >> The strcpy is useful. netdev->name is set as pci_name in front. So the strcpy
> >restores it.
> >
> >Are you doing this just to influence the initial driver log messages?
> 
>  Yes.
> 
> >
> >Don't do that, it's gross.
> 
> Ok, I will remove it.

Before the driver is registered, use dev_info() type of logging.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html