netdev - Re: [PATCH 001/001] smsc95xx: Fix hard_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKh2mn4pK-8=OVkahSZ8VWpX9Va=qCDQUdOONK1FZ75Fbk0Mdg@mail.gmail.com>
Date:	Thu, 16 Aug 2012 10:57:51 +0100
From:	Steve Glendinning <steve@...well.net>
To:	JamesBetts <jimbob.betts@...glemail.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH 001/001] smsc95xx: Fix hard_header_len

Hi James,

Thanks for spotting this, I don't think I've ever tested this device with IMQ.

> -       dev->net->hard_header_len += SMSC95XX_TX_OVERHEAD_CSUM;
> -       dev->hard_mtu = dev->net->mtu + dev->net->hard_header_len;
> +       dev->net->needed_headroom = SMSC95XX_TX_OVERHEAD_CSUM;
> +       dev->hard_mtu = dev->net->mtu + dev->net->hard_header_len +
> dev->net->needed_headroom;

I'm unsure what we *should* be setting hard_header_len and
needed_headroom to.  David?

Thanks,
--
Steve Glendinning
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html