netdev - Re: [PATCH net] net: Remove unused variables in rt_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.01.1208172358220.3927@frira.zrqbmnf.qr>
Date:	Fri, 17 Aug 2012 23:59:15 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...i.de>
To:	David Miller <davem@...emloft.net>
cc:	subramanian.vijay@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: Remove unused variables in rt_cache_stat

On Monday 2012-07-30 23:52, David Miller wrote:

>From: Vijay Subramanian <subramanian.vijay@...il.com>
>Date: Mon, 30 Jul 2012 14:45:50 -0700
>
>> With the removal of the routing cache, some variables in rt_cache_stat are no
>> longer used. Remove them from rt_cache_stat and do not print them out in
>> /proc/net/stat/rt_cache.
>> 
>> Signed-off-by: Vijay Subramanian <subramanian.vijay@...il.com>
>> ---
>> checkpatch complains that the seq_printf line is over 80 chars which was already
>> the case. I left it as is to aid in grepping the sources. 
>
>You cannot make this change, these fields are exported via procfs and
>therefore you will break any application that is parsing the existing
>layout.

Then the fields should just be printed with a static zero, like it's
done in procfs.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html