netdev - Re: [PATCH] xfrm:Use rcu_dereference_bh to deference pointer protected by rcu_read_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1345370326.5158.23.camel@edumazet-glaptop>
Date:	Sun, 19 Aug 2012 11:58:46 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	fan.du@...driver.com, fengguang.wu@...el.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] xfrm:Use rcu_dereference_bh to deference pointer
 protected by rcu_read_lock_bh

On Thu, 2012-08-16 at 23:24 -0700, David Miller wrote:
> I already applied your patch, as I told you here:
> 
> http://marc.info/?l=linux-netdev&m=134517122805719&w=2
> 
> This means you are submitting a patch which doesn't not even apply
> to the net-next tree.
> 
> Instead of continuing to dig yourself deeper and deeper, take a
> break, take a deep breath, and work slowly and carefully.
> --

BTW, we (incorrectly ?) mix RCU and RCU_BH in this file, and since we
use synchronize_rcu() anyway, we should/could use rcu_read_lock()
everywhere we can, as this is less expensive (currently inlined at least
on x86) than rcu_read_lock_bh()

I'll send a cleanup patch on a separate thread


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html