netdev - Re: [PATCH] ipv4: Use netinet->inet_opt in inet_csk_route_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120820.025147.936465141809418575.davem@davemloft.net>
Date:	Mon, 20 Aug 2012 02:51:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	christoph.paasch@...ouvain.be
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: Use netinet->inet_opt in
 inet_csk_route_child_sock()

From: Christoph Paasch <christoph.paasch@...ouvain.be>
Date: Fri, 17 Aug 2012 23:35:12 +0200

> @@ -404,7 +404,7 @@ struct dst_entry *inet_csk_route_child_sock(struct sock *sk,
>  {
>  	const struct inet_request_sock *ireq = inet_rsk(req);
>  	struct inet_sock *newinet = inet_sk(newsk);
> -	struct ip_options_rcu *opt = ireq->opt;
> +	struct ip_options_rcu *opt = rcu_dereference(newinet->inet_opt);
>  	struct net *net = sock_net(sk);

We're not inside of a rcu_read_lock() protected section, so this access
is not legitimate.  If you enabled RCU lock debugging, you would have
triggered a warning in the kernel log.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html