netdev - Re: [PATCH]: net: ipv6: fix oops in inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120820.025822.875182755255293091.davem@davemloft.net>
Date:	Mon, 20 Aug 2012 02:58:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH]: net: ipv6: fix oops in inet_putpeer()

From: Patrick McHardy <kaber@...sh.net>
Date: Sat, 18 Aug 2012 17:32:31 +0200 (MEST)

> The attached patch fixes an oops in inet_putpeer(). Please see the
> changelog entry for details.
> 
> An alternative fix would be to check whether rt6_peer_ptr() returns
> NULL before invoking inet_putpeer(), but properly initializing the
> peer looks cleaner to me.

This is fine for now, applied, thanks Patrick.

There was a built-in assumption that xfrm_fill_dst() would run to
completion before we'd try to release these things, because there in
xfrm6_policy.c's xfrm6_fill_dst, we'd do the rt6_transfer_peer().

But that's obviously not the case if errors happen meanwhile.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html