netdev - Re: [PATCH net v2] net: tcp: move sk_rx_dst_set call after tcp_create_openreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120820.030410.1083547560121610947.davem@davemloft.net>
Date:	Mon, 20 Aug 2012 03:04:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ncardwell@...gle.com, netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net v2] net: tcp: move sk_rx_dst_set call after
 tcp_create_openreq_child()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 19 Aug 2012 15:41:15 +0200

> On Sun, 2012-08-19 at 09:30 -0400, Neal Cardwell wrote:
>> This commit removes the sk_rx_dst_set calls from
>> tcp_create_openreq_child(), because at that point the icsk_af_ops
>> field of ipv6_mapped TCP sockets has not been set to its proper final
>> value.
>> 
>> Instead, to make sure we get the right sk_rx_dst_set variant
>> appropriate for the address family of the new connection, we have
>> tcp_v{4,6}_syn_recv_sock() directly call the appropriate function
>> shortly after the call to tcp_create_openreq_child() returns.
>> 
>> This also moves inet6_sk_rx_dst_set() to avoid a forward declaration
>> with the new approach.
>> 
>> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
>> Reported-by: Artem Savkov <artem.savkov@...il.com>
>> Cc: Eric Dumazet <edumazet@...gle.com>
>> ---
>>  net/ipv4/tcp_ipv4.c      |    1 +
>>  net/ipv4/tcp_minisocks.c |    2 --
>>  net/ipv6/tcp_ipv6.c      |   25 +++++++++++++------------
>>  3 files changed, 14 insertions(+), 14 deletions(-)
> 
> Thanks Neal !
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html