netdev - Re: [PATCH 05/18] netfilter: nf_nat: add protoff argument to packet mangling functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.GSO.4.63.1208201236440.24912@stinky-local.trash.net>
Date:	Mon, 20 Aug 2012 12:37:01 +0200 (MEST)
From:	Patrick McHardy <kaber@...sh.net>
To:	Jan Engelhardt <jengelh@...i.de>
cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 05/18] netfilter: nf_nat: add protoff argument to packet
 mangling functions

On Mon, 20 Aug 2012, Jan Engelhardt wrote:

>
> On Monday 2012-08-20 05:39, Patrick McHardy wrote:
>> index 0bb5a69..4b59a15 100644
>> --- a/include/linux/netfilter/nf_conntrack_amanda.h
>> +++ b/include/linux/netfilter/nf_conntrack_amanda.h
>> @@ -4,6 +4,7 @@
>>
>> extern unsigned int (*nf_nat_amanda_hook)(struct sk_buff *skb,
>> 					  enum ip_conntrack_info ctinfo,
>> +					  unsigned int protoff,
>> 					  unsigned int matchoff,
>> 					  unsigned int matchlen,
>> 					  struct nf_conntrack_expect *exp);
>
> What about using a structure to collect all the accumulating parameters,
> like we do for xtables match functions?

Yes, we could do that for the common parameters.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html