netdev - Re: [PATCH 09/18] netfilter: ipv6: add IPv6 NAT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.GSO.4.63.1208230014420.5113@stinky-local.trash.net>
Date:	Thu, 23 Aug 2012 00:15:31 +0200 (MEST)
From:	Patrick McHardy <kaber@...sh.net>
To:	Jan Engelhardt <jengelh@...i.de>
cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 09/18] netfilter: ipv6: add IPv6 NAT support

On Mon, 20 Aug 2012, Jan Engelhardt wrote:

> On Monday 2012-08-20 05:39, Patrick McHardy wrote:
>> +static struct nf_hook_ops nf_nat_ipv6_ops[] __read_mostly = {
>> +	/* Before packet filtering, change destination */
>> +	{
>> +		.hook		= nf_nat_ipv6_in,
>> +		.owner		= THIS_MODULE,
>> +		.pf		= NFPROTO_IPV6,
>> +		.hooknum	= NF_INET_PRE_ROUTING,
>> +		.priority	= NF_IP_PRI_NAT_DST,
>
> NF_IP6_PRI_NAT_DST
>
>> +		.hook		= nf_nat_ipv6_out,
>> +		.owner		= THIS_MODULE,
>> +		.pf		= NFPROTO_IPV6,
>> +		.hooknum	= NF_INET_POST_ROUTING,
>> +		.priority	= NF_IP_PRI_NAT_SRC,
>
> IP6 too... (2 more occurrences)

Fixed, thanks.

>> +static void nf_nat_ipv6_csum_recalc(struct sk_buff *skb,
>> +				    u8 proto, void *data, __sum16 *check,
>> +				    int datalen, int oldlen)
>> +{
>> +	const struct ipv6hdr *ipv6h = ipv6_hdr(skb);
>> +	struct rt6_info *rt = (struct rt6_info *)skb_dst(skb);
>> +
>> +	if (skb->ip_summed != CHECKSUM_PARTIAL) {
>
> Maybe invert to == CHECKSUM_PARTIAL like in p06/18.

I didn't change the other patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html