netdev - Re: [net-next 12/13] igb: Correct PTP support query from ethtool.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120823112426.GD2238@netboy.at.omicron.at>
Date:	Thu, 23 Aug 2012 13:24:26 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Matthew Vick <matthew.vick@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 12/13] igb: Correct PTP support query from ethtool.

On Thu, Aug 23, 2012 at 02:56:52AM -0700, Jeff Kirsher wrote:
> From: Matthew Vick <matthew.vick@...el.com>
> 
> Update ethtool_get_ts_info to not report any supported functionality on
> 82575 and add support for V2 Sync and V2 Delay packets. In the case
> where CONFIG_IGB_PTP is not defined, we should be reporting default
> values.

> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c

...

> +#endif /* CONFIG_IGB_PTP */
> +	default:
> +		return ethtool_op_get_ts_info(dev, info);

This is wrong. Using this function advertises that you support SW TX
time stamps, which you do not.

Thanks,
Richard

> +		break;
> +	}
>  
>  	return 0;
>  }
> -#endif /* CONFIG_IGB_PTP */
>  
>  static int igb_ethtool_begin(struct net_device *netdev)
>  {
> @@ -2351,9 +2368,7 @@ static const struct ethtool_ops igb_ethtool_ops = {
>  	.get_ethtool_stats      = igb_get_ethtool_stats,
>  	.get_coalesce           = igb_get_coalesce,
>  	.set_coalesce           = igb_set_coalesce,
> -#ifdef CONFIG_IGB_PTP
>  	.get_ts_info            = igb_get_ts_info,
> -#endif /* CONFIG_IGB_PTP */
>  	.begin			= igb_ethtool_begin,
>  	.complete		= igb_ethtool_complete,
>  };
> -- 
> 1.7.11.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html