netdev - Re: [PATCH RFC 0/2] Interface for TCP Metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Aug 2012 19:26:33 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Stephen Hemminger <shemminger@...tta.com>
cc:	netdev@...r.kernel.org
Subject: Re: [PATCH RFC 0/2] Interface for TCP Metrics


	Hello,

On Thu, 23 Aug 2012, Stephen Hemminger wrote:

> Some of netlink API comments:
> 
> 1. My preference is to not make it so granular.
>    I.e make things like RTT a structure with value and variance
>    rather than lots of independent objects.

	Even the ip route used nested objects for metrics.
I preferred not to add fixed structure for them if that is
what you mean. I implemented it in the same way, just like
rtnetlink_put_metrics().

> 2. Make sure netlink API is symmetric. Get should report all
>    values and Set should accept the same values (but ignore
>    if value can not be modified).

	Will take care if one day we support SET request.

> 3. Try and make ip command output invertable, as in what you
>    print is close to what ip command arguments are.

	Any example for what you mean?

> 4. What about monitoring changes?

	I preferred to avoid them because if the routes
are small number and can be monitored, these entries are
modified very often and to me it looked overkill to generate
notification for every update just to notice that nobody
listens for it.

	BTW, I noticed that the GENL part in iproute is
not separated in common place. Should we create common
place for functions like genl_ctrl_resolve_family and
genl_parse_getfamily ?

	Thanks for the comments!

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html