netdev - Re: [net-next 10/13] igb: Tidy up wrapping for CONFIG_IGB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120823172950.GA2192@netboy.at.omicron.at>
Date:	Thu, 23 Aug 2012 19:29:50 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	"Vick, Matthew" <matthew.vick@...el.com>
Cc:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [net-next 10/13] igb: Tidy up wrapping for CONFIG_IGB_PTP.

On Thu, Aug 23, 2012 at 04:09:30PM +0000, Vick, Matthew wrote:
> > -----Original Message-----
> > From: Richard Cochran [mailto:richardcochran@...il.com]
> > Sent: Thursday, August 23, 2012 4:04 AM
> > To: Kirsher, Jeffrey T
> > Cc: davem@...emloft.net; Vick, Matthew; netdev@...r.kernel.org;
> > gospo@...hat.com; sassmann@...hat.com
> > Subject: Re: [net-next 10/13] igb: Tidy up wrapping for CONFIG_IGB_PTP.
> > 
> > On Thu, Aug 23, 2012 at 02:56:50AM -0700, Jeff Kirsher wrote:
> > > From: Matthew Vick <matthew.vick@...el.com>
> > >
> > > For users without CONFIG_IGB_PTP=y, we should not be compiling any
> > PTP
> > > code into the driver. Tidy up the wrapping in igb to support this.
> > 
> > Actually, you are doing more than that. You are adding a bunch of
> > comments onto the already existing #endifs.
> 
> Fair enough. Would you like me to update the patch description?

Better would be to drop of the pendantic #endif /*CONFIG_FOO*/ stuff.
It is just churn.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html