netdev - Re: [net-next 13/13] igb: Store the MAC address in the name in the PTP struct.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1345757737.2579.22.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Thu, 23 Aug 2012 22:35:37 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Richard Cochran <richardcochran@...il.com>
CC:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, <davem@...emloft.net>,
	Matthew Vick <matthew.vick@...el.com>,
	<netdev@...r.kernel.org>, <gospo@...hat.com>,
	<sassmann@...hat.com>, Stuart Hodgson <smhodgson@...arflare.com>
Subject: Re: [net-next 13/13] igb: Store the MAC address in the name in the
 PTP struct.

On Thu, 2012-08-23 at 12:45 +0200, Richard Cochran wrote:
> On Thu, Aug 23, 2012 at 02:56:53AM -0700, Jeff Kirsher wrote:
> > From: Matthew Vick <matthew.vick@...el.com>
> > 
> > Change the name of the adapter in the PTP struct to enable easier
> > correlation between interface and PTP device.
> 
> You want to put the MAC address into the clock name? This is wrong.
> 
> Besides, there is no need for this. The ethool method already makes
> the correlation crystal clear.

The name field is described as 'A short name to identify the clock'.  It
is not stated whether this is meant to be the name of the clock *device*
or the clock *driver*.  If it's the name of the device then some unique
ID such as the permanent MAC address is required.

The ixgbe driver uses MAC addresses and so did the last submitted
version of PHC support for the sfc driver.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html