netdev - Re: [RFC PATCH bridge 4/5] bridge: Add private ioctls to configure vlans on bridge ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120824111113.08b8c1a6@nehalam.linuxnetplumber.net>
Date:	Fri, 24 Aug 2012 11:11:13 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	paulmck@...ux.vnet.ibm.com
Cc:	Vlad Yasevich <vyasevic@...hat.com>, netdev@...r.kernel.org
Subject: Re: [RFC PATCH bridge 4/5] bridge: Add private ioctls to configure
 vlans on bridge ports

On Fri, 24 Aug 2012 10:56:16 -0700
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> wrote:

> > +			return -EPERM;
> > +
> > +		rcu_read_lock();
> > +		if ((p = br_get_port(br, args[1])) == NULL) {
> > +			rcu_read_unlock();
> > +			return -EINVAL;
> > +		}
> > +		rcu_read_unlock();  
> 
> Why is it safe to pass "p" out of the RCU read-side critical section?
> I don't see that br_get_port() does anything to make this safe, at least
> not in v3.5.

It would be accidentally protected by rtnl?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html