netdev - Re: [PATCH] cls_cgroup: Allow classifier cgroups to have their classid reset to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120824.124147.1315942233312740114.davem@davemloft.net>
Date:	Fri, 24 Aug 2012 12:41:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] cls_cgroup: Allow classifier cgroups to have their
 classid reset to 0

From: Neil Horman <nhorman@...driver.com>
Date: Mon, 20 Aug 2012 13:59:10 -0400

> The network classifier cgroup initalizes each cgroups instance classid value to
> 0.  However, the sock_update_classid function only updates classid's in sockets
> if the tasks cgroup classid is not zero, and if it differs from the current
> classid.  The later check is to prevent cache line dirtying, but the former is
> detrimental, as it prevents resetting a classid for a cgroup to 0.  While this
> is not a common action, it has administrative usefulness (if the admin wants to
> disable classification of a certain group temporarily for instance).
> 
> Easy fix, just remove the zero check.  Tested successfully by myself
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>

Applied to net-next, thanks Neil.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html