netdev - Re: [PATCH] cxgb3: remove pointless conditional before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAPgLHd8RKXR-TSnbJLQ2GR28ORB7HTe4kDk8wkwo_e-r+0ue4w@mail.gmail.com>
Date:	Tue, 28 Aug 2012 22:19:57 +0800
From:	Wei Yongjun <weiyj.lk@...il.com>
To:	David.Laight@...LAB.COM
Cc:	divy@...lsio.com, yongjun_wei@...ndmicro.com.cn,
	netdev@...r.kernel.org
Subject: Re: [PATCH] cxgb3: remove pointless conditional before kfree_skb()

On 08/28/2012 09:24 PM, David Laight wrote:
>> -	if (t->nofail_skb)
>> -		kfree_skb(t->nofail_skb);
>> +	kfree_skb(t->nofail_skb);
> Some of these conditionals might be there for performance
> reasons - eg if common path and normally NULL.

I have a quick look at those code, cxgb3_offload_deactivate()
is only used when remove device or device error and then disable
the device, so maybe it is not a common path.




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html