[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.GSO.4.63.1208291443540.1098@stinky-local.trash.net>
Date: Wed, 29 Aug 2012 14:45:16 +0200 (MEST)
From: Patrick McHardy <kaber@...sh.net>
To: Or Gerlitz <ogerlitz@...lanox.com>
cc: davem@...emloft.net, roland@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next V3 0/2] Add rtnl_link_ops support to IPoIB
On Wed, 29 Aug 2012, Or Gerlitz wrote:
> On 23/08/2012 15:15, Or Gerlitz wrote:
>> This is about adding rtnl_link_ops to IPoIB, primarly addressing feedback
>> from Dave on a similar patch that was part of the eIPoIB submission.
>
> Dave, Roland
>
> Any comment on this? The patch was originally submitted through netdev so I
> kept the fixed version to go through that path as well. If this makes things
> easier, we can merge that through net-next.
>
> IPoIB has more proprietary sysfs entries, such as for setting the mode
> (datagram or connected) -- in 2nd thought, non legacy ipoib child interfaces
> created through rtnl shouldn't preserve these prop. mechanisms and use rtnl
> for all sorts of configs, as done for macvlan/8021q etc devices, correct? if
> this is indeed the case, I will fix that and submit V3.
This is how rtnl_link was intended to be used, so you can set and query
all attributes in an atomic fashion and get notifications on changes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists