netdev - Re: [Patch] netpoll: revert 6bdb7fe3104 and fix be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120829.150605.81786816498426745.davem@davemloft.net>
Date:	Wed, 29 Aug 2012 15:06:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, s.munaut@...tever-company.com,
	akpm@...ux-foundation.org, sathya.perla@...lex.com,
	subbu.seetharaman@...lex.com, ajit.khaparde@...lex.com
Subject: Re: [Patch] netpoll: revert 6bdb7fe3104 and fix be_poll() instead

From: Cong Wang <amwang@...hat.com>
Date: Sat, 25 Aug 2012 15:41:11 +0800

> Against -net.
> 
> In the patch "netpoll: re-enable irq in poll_napi()", I tried to
> fix the following warning:
 ...
> by reenabling IRQ before calling ->poll, but it seems more
> problems are introduced after that patch:
> 
> http://ozlabs.org/~akpm/stuff/IMG_20120824_122054.jpg
> http://marc.info/?l=linux-netdev&m=134563282530588&w=2
> 
> So it is safe to fix be2net driver code directly.
> 
> This patch reverts the offending commit and fixes be_poll() by
> avoid disabling BH there, this is okay because be_poll()
> can be called either by poll_napi() which already disables
> IRQ, or by net_rx_action() which already disables BH.
> 
> Reported-by: Andrew Morton <akpm@...ux-foundation.org>
> Reported-by: Sylvain Munaut <s.munaut@...tever-company.com>
> Cc: Sylvain Munaut <s.munaut@...tever-company.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: David Miller <davem@...emloft.net>
> Cc: Sathya Perla <sathya.perla@...lex.com>
> Cc: Subbu Seetharaman <subbu.seetharaman@...lex.com>
> Cc: Ajit Khaparde <ajit.khaparde@...lex.com>
> Signed-off-by: Cong Wang <amwang@...hat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html