netdev - Re: [PATCH 5/7] net/fsl_pq_mdio: streamline probing of MDIO nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120830.133101.155514187705507717.davem@davemloft.net>
Date:	Thu, 30 Aug 2012 13:31:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	timur@...escale.com
Cc:	afleming@...escale.com, netdev@...r.kernel.org
Subject: Re: [PATCH 5/7] net/fsl_pq_mdio: streamline probing of MDIO nodes

From: Timur Tabi <timur@...escale.com>
Date: Wed, 29 Aug 2012 13:08:01 -0500

> Make the device tree probe function more data-driven, so that it no longer
> searches the 'compatible' property more than once.  The of_device_id[] array
> allows for per-entry private data, so we use that to store details about each
> type of node that the driver supports.  This removes the need to check the
> 'compatible' property inside the probe function.
> 
> The driver supports four types on MDIO devices:
> 
> 1) Gianfar MDIO nodes that only map the MII registers
> 2) Gianfar MDIO nodes that map the full MDIO register set
> 3) eTSEC2 MDIO nodes (which map the full MDIO register set)
> 4) QE MDIO nodes (which map only the MII registers)
> 
> Gianfar, eTSEC2, and QE have different mappings for the TBIPA register, which
> is needed to initialize the TBI PHY.  In addition, the QE needs a special
> hack because of the way the device tree is ordered.
> 
> All of this information is encapsulated in the fsl_pq_mdio_data structure,
> so when an MDIO node is probed, per-device data and functions are used
> to determine how to initialize the device.
> 
> Signed-off-by: Timur Tabi <timur@...escale.com>

Applied to net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html