netdev - Re: [Stlinux-devel] [PATCH linux-stm 1/4] net:stmmac: Add check if mdiobus is registered in stmmac_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120831.161243.2158415044562484305.davem@davemloft.net>
Date:	Fri, 31 Aug 2012 16:12:43 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	srinivas.kandagatla@...com
Cc:	netdev@...r.kernel.org, peppe.cavallaro@...com
Subject: Re: [Stlinux-devel] [PATCH linux-stm 1/4] net:stmmac: Add check if
 mdiobus is registered in stmmac_mdio_unregister

From: Srinivas KANDAGATLA <srinivas.kandagatla@...com>
Date: Thu, 30 Aug 2012 16:49:58 +0100

> From: Srinivas Kandagatla <srinivas.kandagatla@...com>
> 
> This patch adds a basic check in stmmac_mdio_unregister to see if mdio
> bus registeration for this driver was actually sucessfull or not.
> 
> Use case here is, if BSP considers using mdio-gpio bus along with stmmac
> driver by passing mdio_bus_data as NULL in platform data.
> Call to stmmac_mdio_register with mdio_bus_data as NULL returns 0, which
> is a considered sucessfull call form stmmac. Then again when we unload
> the driver we just call stmmac_mdio_unregister, this is were the actual
> problem is stmmac-mdio code dont really know at this instance of calling
> that stmmac_mdio_register was actually successful.
> 
> So Adding a check in stmmac_mdio_unregister is always safe.
> 
> Without this patch stmmac driver calls stmmac_mdio_register from
> stmmac_release which Segfaults as mii bus was never registered at the
> first point.
> 
> Originally the this bug was found when unloading an stmmac driver
> instance which uses mdio-gpio for smi access.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html