netdev - Re: [PATCH 1/1] net: fix documentation of skb_needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120831.162420.659402539100971755.davem@davemloft.net>
Date:	Fri, 31 Aug 2012 16:24:20 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	rosenr@...vell.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] net: fix documentation of skb_needs_linearize().

From: Rami Rosen <rosenr@...vell.com>
Date: Tue, 28 Aug 2012 12:39:24 +0300

> skb_needs_linearize() does not check highmem DMA as it does not call
> illegal_highdma() anymore, so there is no need to mention highmem DMA here.
> 
> (Indeed, ~NETIF_F_SG flag, which is checked in skb_needs_linearize(), can
> be set when illegal_highdma() returns true, and we are assured that
> illegal_highdma() is invoked prior to skb_needs_linearize() as
> skb_needs_linearize() is a static method called only once.
> But ~NETIF_F_SG can be set not only there in this same invocation path.
> It can also be set when can_checksum_protocol() returns false).
> 
> see commit 02932ce9e2c136e6fab2571c8e0dd69ae8ec9853,
> Convert skb_need_linearize() to use precomputed features.
> Signed-off-by: Rami Rosen <rosenr@...vell.com>

Applied to net-next, thanks Rami.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html