netdev - Re: [PATCH net-next] r8169: add D-Link DGE-560T identifiers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120831.162852.1143438231808755797.davem@davemloft.net>
Date:	Fri, 31 Aug 2012 16:28:52 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org, in@...log.ru
Subject: Re: [PATCH net-next] r8169: add D-Link DGE-560T identifiers.

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 29 Aug 2012 23:36:31 -0700

> On Wed, 2012-08-29 at 21:40 +0200, Francois Romieu wrote:
>> This one includes a 8168. Not to be confused with the sky2 driven
>> one whose PCI vendor and device ID are the same.
>>
>> Reported-by: Neyuki Inaya <in@...log.ru>
>> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
>> ---
>> 
>>  The patch applies to Linus's branch as well.
>> 
>>  drivers/net/ethernet/realtek/r8169.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
>> index b47d5b3..ab1cc56 100644
>> --- a/drivers/net/ethernet/realtek/r8169.c
>> +++ b/drivers/net/ethernet/realtek/r8169.c
>> @@ -288,6 +288,8 @@ static DEFINE_PCI_DEVICE_TABLE(rtl8169_pci_tbl) = {
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8168), 0, 0, RTL_CFG_1 },
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8169), 0, 0, RTL_CFG_0 },
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK,	0x4300), 0, 0, RTL_CFG_0 },
>> +	{ PCI_VENDOR_ID_DLINK,			0x4300,
>> +		PCI_VENDOR_ID_DLINK, 0x4b10,		 0, 0, RTL_CFG_1 },
> 
> This has no effect, as the preceding entry will match all the same
> devices.  I think you need to insert it before that.

Francois please fix up this patch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html