netdev - Re: [PATCH 0/3] tcp: TCP Fast Open, Server Side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPshTCgxo==q1Om1vrfi9auZ4eHv=Vtte6ijk3+tzaBk9_vH6g@mail.gmail.com>
Date:	Fri, 31 Aug 2012 15:27:41 -0700
From:	Jerry Chu <hkchu@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	ycheng@...gle.com, edumazet@...gle.com, ncardwell@...gle.com,
	sivasankar@...ucsd.edu, therbert@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH 0/3] tcp: TCP Fast Open, Server Side

On Fri, Aug 31, 2012 at 1:53 PM, David Miller <davem@...emloft.net> wrote:
> From: "H.K. Jerry Chu" <hkchu@...gle.com>
> Date: Thu, 30 Aug 2012 16:39:05 -0700
>
>> This patch series provides the server (passive open) side code
>> for TCP Fast Open. Together with the earlier client side patches
>> it completes the TCP Fast Open implementation.
>
> Build warnings:
>
> net/ipv4/tcp_ipv4.c: In function ‘tcp_v4_conn_request’:
> net/ipv4/tcp_ipv4.c:1480:25: warning: unused variable ‘fastopenq’ [-Wunused-variable]
>
> Please address this and Eric Dumazet's feedback, thanks.

Thanks for catching this (a manual mistake while trying to keep my three TFO
server patches for three different kernel versions all in sync). I
also discovered
and fixed another small merge error - "do_fastopen" in tcp_v4_conn_request() no
longer needs to be init'ed to 0.

Will send in v2 in a minute.

Jerry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html