netdev - [PATCH net-next 0/12] qlcnic: patches for new adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1346452619-2129-1-git-send-email-sony.chacko@qlogic.com>
Date:	Fri, 31 Aug 2012 18:36:47 -0400
From:	Sony Chacko <sony.chacko@...gic.com>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org, Dept_NX_Linux_NIC_Driver@...gic.com,
	Sony Chacko <sony.chacko@...gic.com>
Subject: [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA

From: Sony Chacko <sony.chacko@...gic.com>

>From: David Miller [mailto:davem@...emloft.net]

>Firstly, I'm not going to let you create arbitrary new sysfs
>and debugfs crap for facilities that are already supported by
>the kernel via other interfaces.

>For example, providing a facility to read and write the PCI BARs
>is completely pointless.  Use the PCI config space access APIs for
>this if you want to do this from userspace.

>The patches are also much more verbose than they need to be.
>When you move an operation to the new hwops, keep the existing function
>name but make it an inline function that invokes the hwop.

>That way you won't need hundreds of lines in your patch that look like this:

>-	qlcnic_clear_lb_mode(adapter);
>+	ahw->hw_ops->clear_loopback(adapter, mode);

>Instead you'd have:

>static inline void qlcnic_clear_lb_mode(struct qlcnic_adapter *adapter,
>							u8 mode) {
>	struct qlcnic_hardware_context *ahw = &adapter->ahw;

>	ahw->hw_ops->clear_loopback(adapter, mode); }

>From: David Miller [mailto:davem@...emloft.net] 
>Sent: Friday, August 31, 2012 1:05 PM

> +static inline int
> +qlcnic_config_led(struct qlcnic_adapter *adapter, u32 state, u32 
> +rate) {
> +	return adapter->nic_ops->config_led(adapter, state, rate);
> +
> +}
> +

>Please get rid of those unnecessary empty lines in the function bodies.


I have made the changes as you suggested above,
please drop all the previous 12 patches.
We are not creating new sysfs nodes.

Please apply the updated patch series to net-next.

Thanks,
Sony
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html